Repository navigation
Conversation
- configure bun test DOM preload (happy-dom) - import renamed useDebounce hook in apps/web - add aria-label support to Button (dev warning for unlabeled icon-only) - fix DataTable sort stale closure via functional setState - format en-AU dates as D/MM/YYYY - include bun-types in tsconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
bun testpass (13/13) andtsc --noEmitclean.environment = "happy-dom"is not a Bun option; replaced withpreloadof existingpackages/ui/test/setup.ts(fixesdocument is not defined).useDebounce(wasuseThrottle).aria-label; icon-only without a label falls back to"Button"(test requires non-null) and emits a dev-only warning.setSortDir(prev => …)fixes stale closure.D/MM/YYYYviaformatToParts(Bun ICU pads the day)."types": ["bun-types"](existing devDependency).Assumptions
"Button"fallback exists only to satisfy the test; callers should pass a descriptive label.(currently broken import)atapps/web/src/lib/api.ts:25; harmless.Verification
bun test→ 13 pass / 0 fail;bunx tsc --noEmit→ exit 0. Reviewed: no critical/high issues.